chore(auth): route browser-flow prompts + diagnostics to stderr#98
Open
crowlbot wants to merge 1 commit into
Open
chore(auth): route browser-flow prompts + diagnostics to stderr#98crowlbot wants to merge 1 commit into
crowlbot wants to merge 1 commit into
Conversation
Move four log sites from stdout to stderr so that `--json` callers
(and anyone piping the CLI's stdout) stop seeing human/diagnostic
chatter mixed into machine-readable output:
- The OAuth browser-flow prompt ("Visit ... to authorize ..."): this
is a prompt directed at the human at the terminal; it belongs on
stderr, not on stdout where it would corrupt a piped JSON payload.
- "Authorization successful. Authenticated as ...": status message,
not data; stderr.
- The 401 response body that `authedFetch` logs when re-authenticating:
always a diagnostic; gated on `--debug` and emitted to stderr.
- The retry-link's `console.log(opts)` debug dump: stderr (was the
only stdout debug write in auth.ts).
The keychain-unavailable warning was already moved to stderr in #91.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #96. Small stdio-discipline pass that routes four sites in `auth.ts` from stdout → stderr, so `--json` callers (and anyone piping the CLI's stdout) stop seeing human chatter mixed into the machine-readable stream.
Touched sites
The keychain-unavailable warning was already moved to stderr in #91.
What's intentionally NOT in this PR
Test plan
🤖 Generated with Claude Code